Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate empty .guardedHandlers #24

Closed
dherman opened this issue Feb 15, 2015 · 3 comments · Fixed by #48
Closed

Eliminate empty .guardedHandlers #24

dherman opened this issue Feb 15, 2015 · 3 comments · Fixed by #48
Labels
question

Comments

@dherman
Copy link

dherman commented Feb 15, 2015

I filed a premature drive-by fix to this in this failed PR but we need consensus first. I propose we eliminate the empty .guardedHandlers from the spec since it serves no purpose -- the deprecated spec includes the full definition and meanwhile tools can harmlessly produce an empty .guardedHandlers array and be spec-compliant so it seems likes a harmless fix.
This was referenced Feb 15, 2015
Closed
Closed
@ariya ariya mentioned this issue Feb 16, 2015
Closed
@RReverser
Copy link
Member

@mikesherov Thoughts on this? Looks reasonable to me.

@mikesherov
Copy link
Contributor

Yes, reasonable. Feel free to submit a PR that moves gaurdedHandlers to deprecated.

RReverser added a commit that referenced this issue Mar 8, 2015
@RReverser
Remove empty TryStatement.guardedHandlers
20aa69a 
Closes #24
@RReverser RReverser mentioned this issue Mar 8, 2015
Merged
@RReverser
Copy link
Member

guardedHandlers itself is already in deprecated, and only empty case is not removed in spec, so here it is: #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove empty TryStatement.guardedHandlers estree/estree
3 participants
@dherman @mikesherov @RReverser