Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

singular .handler property? #1

Closed
dherman opened this issue Feb 12, 2015 · 10 comments
Closed

singular .handler property? #1

dherman opened this issue Feb 12, 2015 · 10 comments
Assignees

Comments

@dherman
Copy link

dherman commented Feb 12, 2015

Back in 2012 I suggested a backwards-incompatible tweak to the TryStatement API to have a handler property instead of handlers, and it looks like Esprima's change didn't match it. So now SpiderMonkey and Esprima do not behave compatibly for TryStatements.

The change would have been a more reasonable API but is it way too late for implementations to change to match it?

If we can't change implementations, then the spec should have handlers instead of handler and I'll file a SpiderMonkey bug to match that behavior.

@sebmck
Copy link

sebmck commented Feb 12, 2015

@dherman
Copy link
Author

dherman commented Feb 12, 2015

Thanks! From those conversations it looks like it's unlikely anyone is willing to break compatibility on this, but it'd be nice to hear confirmation before closing the question definitively.

@mikesherov
Copy link
Contributor

Esprima is going to change to handler in our next major build.

@dherman
Copy link
Author

dherman commented Feb 12, 2015

Great news!

@mikesherov
Copy link
Contributor

@sebmck acorn already does handler?

@sebmck
Copy link

sebmck commented Feb 12, 2015

@mikesherov Yep

@mikesherov
Copy link
Contributor

Sounds like we can close this and say handler it stays! @dherman close if you're satisfied. Perhaps we should add an errata section or add handlers to deprecated if it isn't already?

@mikesherov
Copy link
Contributor

Ah actually, someone needs to PR this change. @dherman I choose you!

@ariya
Copy link
Contributor

ariya commented Feb 13, 2015

@dherman Are we keeping the empty guardedHandlers for now?

@dherman
Copy link
Author

dherman commented Feb 15, 2015

@ariya I filed this in issue #24.

btmills added a commit to eslint/js that referenced this issue Mar 4, 2015
This is a port of jquery/esprima#1034. It adds `handler` while leaving
`handlers` unchanged. `handler` was decided upon in estree/estree#1.
btmills added a commit to eslint/js that referenced this issue Mar 4, 2015
This is a port of jquery/esprima#1034. It adds `handler` while leaving
`handlers` unchanged. `handler` was decided upon in estree/estree#1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants