-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
singular .handler property? #1
Comments
Thanks! From those conversations it looks like it's unlikely anyone is willing to break compatibility on this, but it'd be nice to hear confirmation before closing the question definitively. |
Esprima is going to change to |
Great news! |
@sebmck acorn already does handler? |
@mikesherov Yep |
Sounds like we can close this and say |
Ah actually, someone needs to PR this change. @dherman I choose you! |
@dherman Are we keeping the empty |
This is a port of jquery/esprima#1034. It adds `handler` while leaving `handlers` unchanged. `handler` was decided upon in estree/estree#1.
This is a port of jquery/esprima#1034. It adds `handler` while leaving `handlers` unchanged. `handler` was decided upon in estree/estree#1.
Back in 2012 I suggested a backwards-incompatible tweak to the TryStatement API to have a
handler
property instead ofhandlers
, and it looks like Esprima's change didn't match it. So now SpiderMonkey and Esprima do not behave compatibly for TryStatements.The change would have been a more reasonable API but is it way too late for implementations to change to match it?
If we can't change implementations, then the spec should have
handlers
instead ofhandler
and I'll file a SpiderMonkey bug to match that behavior.The text was updated successfully, but these errors were encountered: