Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Material Theme has bright red lines #699

Closed
davidsneighbour opened this issue Oct 27, 2023 · 3 comments
Closed

Issue: Material Theme has bright red lines #699

davidsneighbour opened this issue Oct 27, 2023 · 3 comments
Labels
Projects

Comments

@davidsneighbour
Copy link

Describe the bug
I am not a big theme buff, but today I thought "let's install a theme" and after I installed the "Community Material Theme Darker High Contrast" all lines in the FM Dashboard were bright red.

Selection_003

This clashes with the turquoise of FM. Restarting didn't change anything. Changing back to the normal theme fixes it. Thus ends my journey into VSCode themes.

I could not find anything else being of this color in the theme.

I am not sure if this is a bug as in those borders taking their color value from different settings in specific themes or if this is just something people who like themes (not me) have to live with.

Desktop (please complete the following information):

  • OS: Ubuntu 22.04
  • Latest non-beta FrontMatter
@davidsneighbour davidsneighbour added the bug Something isn't working label Oct 27, 2023
@estruyf
Copy link
Owner

estruyf commented Oct 27, 2023

The color is coming from the theme you've selected, in this case, the border of some element for the Community Material Theme Darker High Contrast is set to red.

I will do a change to another border color variable, which will fix the issue for the theme and other themes should not be impacted by it.

@estruyf estruyf added this to To do in 9.4.0 via automation Oct 27, 2023
@estruyf estruyf moved this from To do to In progress in 9.4.0 Oct 27, 2023
estruyf added a commit that referenced this issue Oct 27, 2023
@estruyf
Copy link
Owner

estruyf commented Oct 27, 2023

@davidsneighbour available for testing in the latest beta.

@davidsneighbour
Copy link
Author

Yes, looking good. Thanks.

9.4.0 automation moved this from In progress to Done Oct 27, 2023
@estruyf estruyf mentioned this issue Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
9.4.0
Done
Development

No branches or pull requests

2 participants