Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: Transliteration error in action Optimise slug #711

Closed
Aharito opened this issue Nov 16, 2023 · 4 comments
Closed

Bug report: Transliteration error in action Optimise slug #711

Aharito opened this issue Nov 16, 2023 · 4 comments

Comments

@Aharito
Copy link

Aharito commented Nov 16, 2023

Describe the bug
The 'ь' character is not transliterated by click the Optimise slug, despite it presented is in the vscode-front-matter/src/constants file /charMap.ts here and here

To Reproduce
Steps to reproduce the behavior:

  1. Create any .md file in FrontMatterCMS project.
  2. Initialize project
  3. Goto FrontMatter Actions
  4. In "Title" field write for example 'конь' (a word with the 'ь' sybmol)
  5. Click to "Optimise slug" button
  6. The 'slug: konь' string appears on front matter area in file

Expected behavior
Symbols 'ь' (lowercase) and 'Ь' (uppercase) must be transiterated as empty string ''

Screenshots
image

Desktop (please complete the following information):

  • OS: Win 10
  • VSCode Version: 1.83.0
@Aharito Aharito added the bug Something isn't working label Nov 16, 2023
@estruyf
Copy link
Owner

estruyf commented Nov 16, 2023

I see; that is the only character that doesn't have value. You are better suited to know if it needs a value or not.

Does ь need to be replaced by another character, or should it be empty?

estruyf added a commit that referenced this issue Nov 16, 2023
@estruyf
Copy link
Owner

estruyf commented Nov 16, 2023

At least the bug is fixed right now in the latest beta version.

@estruyf estruyf added this to To do in 9.4.0 via automation Nov 16, 2023
@estruyf estruyf moved this from To do to In progress in 9.4.0 Nov 16, 2023
@Aharito
Copy link
Author

Aharito commented Nov 17, 2023

Does ь need to be replaced by another character, or should it be empty?

It should be empty. Symbols 'ь' (lowercase) and 'Ь' (uppercase) must be transiterated as empty string ''.

P.S. Thank for quick answer and for great FrontMatterCMS extension

@estruyf
Copy link
Owner

estruyf commented Nov 17, 2023

Great! Thanks for the feedback.

@estruyf estruyf moved this from In progress to Done in 9.4.0 Dec 8, 2023
@estruyf estruyf mentioned this issue Dec 12, 2023
@estruyf estruyf closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
9.4.0
Done
Development

No branches or pull requests

2 participants