Skip to content

Bug report: Transliteration error in action Optimise slug #711

Description

@Aharito

Describe the bug
The 'ь' character is not transliterated by click the Optimise slug, despite it presented is in the vscode-front-matter/src/constants file /charMap.ts here and here

To Reproduce
Steps to reproduce the behavior:

  1. Create any .md file in FrontMatterCMS project.
  2. Initialize project
  3. Goto FrontMatter Actions
  4. In "Title" field write for example 'конь' (a word with the 'ь' sybmol)
  5. Click to "Optimise slug" button
  6. The 'slug: konь' string appears on front matter area in file

Expected behavior
Symbols 'ь' (lowercase) and 'Ь' (uppercase) must be transiterated as empty string ''

Screenshots
image

Desktop (please complete the following information):

  • OS: Win 10
  • VSCode Version: 1.83.0

Activity

  1. estruyf commented on Nov 16, 2023

    @estruyf
    Owner

    I see; that is the only character that doesn't have value. You are better suited to know if it needs a value or not.

    Does ь need to be replaced by another character, or should it be empty?

  2. added a commit that references this issue on Nov 16, 2023
  3. estruyf commented on Nov 16, 2023

    @estruyf
    Owner

    At least the bug is fixed right now in the latest beta version.

  4. Aharito commented on Nov 17, 2023

    @Aharito
    Author

    Does ь need to be replaced by another character, or should it be empty?

    It should be empty. Symbols 'ь' (lowercase) and 'Ь' (uppercase) must be transiterated as empty string ''.

    P.S. Thank for quick answer and for great FrontMatterCMS extension

  5. estruyf commented on Nov 17, 2023

    @estruyf
    Owner

    Great! Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    • Status
      Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions