Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Japanese Translation #727

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Added Japanese Translation #727

merged 4 commits into from
Jan 9, 2024

Conversation

mayumih387
Copy link
Contributor

PR Details

Translation into Japanese:

  • package.nls.ja.json
  • l10n/bundle.l10n.ja.json

Description

New contexts are added and translated from the original package.nls.json and l10n/bundle.l10n.json based on 78bfa62.
Most of them have been translated, except for 2 following lines;

l10n/bundle.l10n.json

  • 468 "commands.article.notification.noTaxonomy"
  • 641 "helpers.questions.selectContentFolder.quickPick.noFolders.warning"

This is because I couldn't be sure in which situation these phrases would appear. I have added 馃毀 to these lines. If necessary, please delete the marker, or if the practical information for these phrases is available, I can add translations.

Related Issue

none

Motivation and Context

For Japanese users

How Has This Been Tested

  • on local
  • vsce

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@estruyf
Copy link
Owner

estruyf commented Jan 9, 2024

@mayumih387 amazing work! Will verify the two lines and let you know what to do. Thank you!

@estruyf
Copy link
Owner

estruyf commented Jan 9, 2024

The first one can be ignored, this is coming from old functionality. Will remove the reference.

@estruyf
Copy link
Owner

estruyf commented Jan 9, 2024

The second one is obsolete as well, because, when there are no page folders configured, the welcome view will be shown to highlight configuration is missing.

Just did the changes and will merge your PR.

@estruyf estruyf merged commit f9134f1 into estruyf:dev Jan 9, 2024
1 check passed
@estruyf
Copy link
Owner

estruyf commented Jan 9, 2024

The release is building and can soon be tested! Thanks again! 馃挴

@mayumih387
Copy link
Contributor Author

Thanks for checking! Please let me know if any further translation is needed :)

@estruyf
Copy link
Owner

estruyf commented Jan 16, 2024

@mayumih387 just pushed a commit for #731, which includes a couple of new keys that might need translation. Would you be able to help translating those?

@mayumih387
Copy link
Contributor Author

I'd love to. I'm sending a new PR.

@estruyf estruyf mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants