Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the "Waiting for new logs" spinner should indicate whether it's waiting or loading? #976

Open
jshearer opened this issue Feb 8, 2024 · 1 comment
Labels
enhancement New feature or request ops logs Any recommendations related to ops logs

Comments

@jshearer
Copy link
Contributor

jshearer commented Feb 8, 2024

I love the "waiting for new logs" spinner, but one thing I liked about the previous iteration was that it told me explicitly when it had reached the end and there were genuinely no new logs to present. Currently, it seems that the spinner is shown at all times, whether it's actively loading new logs to present, or truly waiting for new logs to show up. Is it possible to differentiate somehow between being caught up to the present time, vs loading more logs to display?

@jshearer jshearer added the ops logs Any recommendations related to ops logs label Feb 8, 2024
@travjenkins
Copy link
Member

travjenkins commented Feb 8, 2024

It is shown at all times because it is checking for new logs every 500 ms. It never really stops.

I tried this out and it ended up feeling more like a bug with the spinner as it was stopping and starting a lot and felt like the spinner was just breaking and stuck in a loop.

I had considered adding some kind of "Last Checked" like how we do for stats.
image

@travjenkins travjenkins added the enhancement New feature or request label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ops logs Any recommendations related to ops logs
Projects
None yet
Development

No branches or pull requests

2 participants