Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for name attribute on filters #164

Closed
wants to merge 1 commit into from

Conversation

dylanlgs
Copy link

This Pull Request adds support for including a name attribute on a filter. The use case is running tests written in Gherkin; the name attribute allows us to use a native method for filling a form field with a specified value.

For example:

#...
When I go to the shoes page
And I enter "Nike" in the brand field
Then I should see #...

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling e0553c9 on dylanlgs:filter-name into c83e219 on esvit:master.

@esvit
Copy link
Owner

esvit commented Jan 10, 2014

OK, I'll add this feature, but you must been add your code in source files, not ng-table.src.js because it build automatically. I think I describe development process in readme.

@esvit esvit closed this Jan 10, 2014
@dylanlgs
Copy link
Author

Maybe I'm missing something, but I don't see a contributor guide in readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants