refactor(filters): name of filter input defined by the filter key rather...

[christianacca]

... than a separate $$name field

Now a filter input's name is set to the filter key. Eg:

Given: <td filter="{'username': 'text'}"</td>
Results in the filter input: <input name='username'/>

Previously:

• Unless $$name was supplied, a filter input's name was incorrectly set to 'false'
• When $$name was supplied, multiple filters defined by the same filter definition would share the same name

BREAKING CHANGE:

• $$name field on filter definitions is not supported.

Previously:

<td filter="{'username': 'text', $$name: 'username'}"</td>

... now becomes:

<td filter="{'username': 'text'}"</td>

• column.filterName has been dropped as this is no longer applicable. Custom filter templates will need to change.

Previously:

        <input type="text" name="{{column.filterName}}"

... now becomes:

        <input type="text" name="{{name}}"

• Multiple filters defined by the same filter definition will now render each input with a seperate name.

[christianacca]

Guys,

I'm introducing a breaking change here so want to make it more visible by creating a pull request.

I think my changes are justified. Here's ,my thought process...

I've spent time looking at how the original feature of allowing a name to be assigned to a filter input:

• Original PR: Add support for name attribute on filters #164
• Final commit: 568fea5

I strongly suspect that the original change was done quickly by copying some previous code - code that introduced the ability to specify the url to a filter template: #40

I don't think the code that was copied was a good design. I think that the url should have been the filter value rather than introduce a separate templateURL field. In fact I've committed a change that allows for just that: 7955f12

So rather than use the copy and paste code, I think a simpler and cleaner design is to use the filter key as the filter input name.

Hopefully the breaking changes I've made will only affect a very small set of developers - those using the this undocumented $$name field.

C