Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reload if not initialized #296

Closed
wants to merge 1 commit into from
Closed

Conversation

cboden
Copy link

@cboden cboden commented Apr 29, 2014

I've had the scenario come up a couple times where my data model is updated before ng-table is "ready". This prevents something from triggering reload and having a javascript error.

@AGiorgetti
Copy link

I'm having this very same problem too, also if you look at Example #14 you will find a piece of code like this:
$scope: { $data: {} }
attached to the ngTableParams object, I think that it's there to mitigate some of these errors, but it can lead to other internal side effects, because you are not completely mocking the scope object (it's missing the $emit function, which is used elsewhere in ngTable source).

ghost referenced this pull request in ifeelgoods/ng-table Jun 13, 2014
@iyeldinov iyeldinov added this to the v0.4.3 milestone Jan 18, 2015
@iyeldinov iyeldinov closed this Jan 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants