Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running esy with an out of date esy pesy, should fail to build. #75

Closed
jordwalke opened this issue Oct 14, 2019 · 3 comments
Closed

Running esy with an out of date esy pesy, should fail to build. #75

jordwalke opened this issue Oct 14, 2019 · 3 comments

Comments

@jordwalke
Copy link
Member

If you forgot to run esy pesy after changing the package.json in a way that affects the output generated files, then running esy or esy build should fail. This is lower priority, but would be nice. The way it's done is that there would be two commands.

build: "pesy refmterr dune build -p package-name",
buildDev: "dune build -p package-name"

Where pesy knows it's running in the esy build environment instead of as an esy pesy command. We discussed this and it wasn't so easy to detect which of the modes we're in, but thought I'd make a task to track this feature.

@ManasJayanth
Copy link
Member

Another issue was that we wanted pesy to be build dependency. build: "pesy refmterr dune build -p package-name unfortunately requires it to be a regular one.

This reason we wanted pesy to be dev only dependency was because of dependency conflicts. If pesy can run in build env (during a regular non dev build), then even scoped package names handled well

@ulrikstrid
Copy link
Contributor

Shouldn't pesy and refmterr be used in buildDev and not build?

@ManasJayanth
Copy link
Member

Closed by #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants