Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reading external register with 0 latency #19

Merged
merged 5 commits into from
Mar 6, 2023

Conversation

Xtyll
Copy link
Collaborator

@Xtyll Xtyll commented Apr 18, 2022

Problems:

  • In case of 0 latency response of the external registers user have incorrect data with AXILite and Avalon bus
  • In case of APB bus and 0 latency bridge local bus <> APB was broken

What's new:

  • Added tests with 0 latency to the bridges TB
  • Added tests with 0 latency to regmap TB

What's fixed:

  • APB bus in case of 0 latency read response
  • regmap in case of 0 latency read response from external response (FWFT FIFO)

Note:
Added one additional clock delay to data reading just to implement the same code for zero and non-zero latency cases

@stridge-cruxml
Copy link
Contributor

stridge-cruxml commented Jul 28, 2022

Hi @Xtyll,

You are correct, thanks for the fix!

I have verified that this fixes the issue with the verilog version (i didn't test the others).

Sorry for the slow reply too.

@arnfol arnfol added the bug Something isn't working label Mar 6, 2023
@arnfol arnfol self-assigned this Mar 6, 2023
@arnfol arnfol requested review from arnfol and removed request for esynr3z March 6, 2023 12:18
Copy link
Collaborator

@arnfol arnfol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I've also checked vhdl generation with my testbench.

@arnfol arnfol merged commit 704b3ad into master Mar 6, 2023
@arnfol arnfol deleted the fix/zero_latency_read branch March 6, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants