Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add captchetat #159

Merged
merged 48 commits into from
Oct 27, 2022
Merged

Feat/add captchetat #159

merged 48 commits into from
Oct 27, 2022

Conversation

nicolaskempf57
Copy link
Contributor

@nicolaskempf57 nicolaskempf57 commented Sep 12, 2022 •
edited by maudetes
Loading

@quaxsze quaxsze mentioned this pull request Sep 15, 2022
Closed
@nicolaskempf57 nicolaskempf57 marked this pull request as ready for review September 22, 2022 10:15
maudetes
maudetes reviewed Oct 11, 2022
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It seems to work well! 👏

I have some additional comments on the code :)

udata_front/theme/gouvfr/templates/security/register_user.html Outdated Show resolved Hide resolved
cypress/integration/register.js Outdated Show resolved Hide resolved
udata_front/api.py Outdated Show resolved Hide resolved
udata_front/api.py Outdated Show resolved Hide resolved
udata_front/api.py Outdated Show resolved Hide resolved
udata_front/api.py Show resolved Hide resolved
udata_front/settings.py Outdated Show resolved Hide resolved
udata_front/settings.py Outdated Show resolved Hide resolved
udata_front/settings.py Outdated Show resolved Hide resolved
udata_front/frontend/__init__.py Outdated Show resolved Hide resolved
maudetes
maudetes reviewed Oct 20, 2022
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some small comments and I think we'll be good.

Don't forget the changelog! ;)

udata_front/theme/gouvfr/templates/security/register_user.html Show resolved Hide resolved
udata_front/api.py Show resolved Hide resolved
udata_front/api.py Outdated Show resolved Hide resolved
udata_front/settings.py Outdated Show resolved Hide resolved
maudetes
maudetes reviewed Oct 24, 2022
View reviewed changes
udata_front/settings.py Outdated Show resolved Hide resolved
udata_front/api.py Show resolved Hide resolved
maudetes
maudetes reviewed Oct 24, 2022
View reviewed changes
udata_front/api.py Outdated Show resolved Hide resolved
maudetes
maudetes approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're all clear! Well done for this! 👏

maudetes
maudetes approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@nicolaskempf57 nicolaskempf57 merged commit a22c33c into datagouv:master Oct 27, 2022
@nicolaskempf57 nicolaskempf57 deleted the feat/add-captchetat branch October 27, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte abulte left review comments

@maudetes maudetes maudetes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ajouter un système de captcha sur la page de création de compte
4 participants
@nicolaskempf57 @abulte @maudetes @quaxsze