Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to flask-rest-x #165

Merged
merged 7 commits into from
Oct 20, 2022
Merged

Switch to flask-rest-x #165

merged 7 commits into from
Oct 20, 2022

Conversation

quaxsze
Copy link
Contributor

@quaxsze quaxsze commented Oct 13, 2022

Need to merge opendatateam/udata#2770 first to compile deps files.

Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Let's merge after opendatateam/udata#2770 and a successful CI :)

@@ -14,6 +14,7 @@
- Cache behavior changes [#154](https://github.com/etalab/udata-front/pull/154):
- Organization and Reuse display page are now cached.
- Cache keys now embed the `last_modified` object attribute. This automatically invalidates the cache when modifying the object.
- Switch from `Flask-restplus` to its fork `Flask-rest-x` [#165](https://github.com/etalab/udata-front/pull/165)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not in the Current section

@maudetes
Copy link
Contributor

For the lighthouse error, a suggestion would be to add a pip install udata.in before the pip install -e . in https://github.com/etalab/udata-front/blob/ba915f19afc36883c6787b5b2b9545d6b636dfd9/.circleci/config.yml#L168?

@quaxsze quaxsze merged commit 0c9ba96 into master Oct 20, 2022
@quaxsze quaxsze deleted the flask-rest-x branch October 20, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants