Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add theme view for mail change #192

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Add theme view for mail change #192

merged 3 commits into from
Jan 17, 2023

Conversation

quaxsze
Copy link
Contributor

@quaxsze quaxsze commented Jan 11, 2023 •
edited by maudetes
Loading

maudetes
maudetes reviewed Jan 13, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Minor comments :)

Don't forget changelog ;)

udata_front/theme/gouvfr/templates/security/change_email.html Outdated Show resolved Hide resolved
udata_front/theme/gouvfr/templates/security/change_email.html Outdated Show resolved Hide resolved
@quaxsze quaxsze requested a review from maudetes January 16, 2023 15:28
maudetes
maudetes approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're all clear! 👏

@quaxsze quaxsze merged commit c8689b1 into master Jan 17, 2023
@quaxsze quaxsze deleted the emailChangeFeature branch January 17, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maudetes maudetes maudetes approved these changes

@nicolaskempf57 nicolaskempf57 Awaiting requested review from nicolaskempf57

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@quaxsze @maudetes