Add version in js chunk file name #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies to _commonjsHelpers only in our case
nicolaskempf57
approved these changes
Apr 17, 2023
|
|
If loading static chunks, use inline_burst. Add package.json as bumpr files, to keep in sync
Somehow, setuptools version installed doesn't seem to be the correct 66.1.1 in cache
maudetes
changed the title
maudetes
commented
Apr 17, 2023
There was a problem hiding this comment.
We've opted for using the package version in the chunk file names, thus having the [name].[version].js pattern.
We use bumpr to keep the version number in sync when releasing.
We've added an option in theme_static to use this pattern instead of the default dummy param version (?_=version).
Additionally, I've had an issue with setuptools version being installed. I'm unclear why, but it seems that it doesn't use the specify version if we don't do a force-reinstall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to _commonjsHelpers only in our case.
It allows us to version this file, preventing using a previous cached version that has changed.