Redirect *pages* when missing trailing slash #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update existing tests to call slug with trailing slash to prevent redirect
quaxsze
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix datagouv/data.gouv.fr#1097
Having a trailing slash in
@blueprint.route('/pages/<path:slug>/')did not apply redirect when missing trailing slash, due topath:Variable Rule.Removed the explicit trailing slash in the route but added an explicit redirect if missing. We try to mimic the trailing slash behavior applied by flask in other cases (described in https://flask.palletsprojects.com/en/2.1.x/quickstart/#unique-urls-redirection-behavior).
There may be a better way to have the trailing slash redirect behavior with
:pathVariable Rule, without having to code it explicitly, but I haven't found find it yet.