Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed: hope embed etcd can register HTTP handler #6014

Closed
siddontang opened this issue Jul 21, 2016 · 2 comments
Closed

embed: hope embed etcd can register HTTP handler #6014

siddontang opened this issue Jul 21, 2016 · 2 comments

Comments

@siddontang
Copy link
Contributor

Hi

We embed etcd in our project, and our project also uses HTTP like listening port 9090.

I think it is better to use only one HTTP port 2379, so maybe we can register our own HTTP handler in etcd mux too. Of course, we must guarantee ourself that the router path can't conflict with etcd's.

@xiang90 xiang90 added this to the v3.1.0-maybe milestone Jul 21, 2016
@xiang90
Copy link
Contributor

xiang90 commented Jul 21, 2016

@siddontang

This should not be hard. All we need to is to expose https://github.com/coreos/etcd/blob/master/embed/serve.go#L75 and https://github.com/coreos/etcd/blob/master/embed/serve.go#L103 in https://github.com/coreos/etcd/blob/master/embed/etcd.go#L52 as listeners. Do you want to give it a try? Thanks.

@xiang90
Copy link
Contributor

xiang90 commented Jul 28, 2016

Closed by #6063

@xiang90 xiang90 closed this as completed Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants