Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update x/sys and x/net modules to support Risc-V #10834

Merged
merged 1 commit into from
Aug 29, 2019
Merged

vendor: update x/sys and x/net modules to support Risc-V #10834

merged 1 commit into from
Aug 29, 2019

Conversation

carlosedp
Copy link
Contributor

Updating projects using libraries that were recently updated to support Risc-V architecture.

Go upstream work is tracked on: golang/go#27532

Risc-V software support tracker on https://github.com/carlosedp/riscv-bringup

Signed-off-by: CarlosEDP me@carlosedp.com

@codecov-io
Copy link

codecov-io commented Jun 18, 2019

Codecov Report

Merging #10834 into master will increase coverage by 0.63%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10834      +/-   ##
==========================================
+ Coverage   63.83%   64.47%   +0.63%     
==========================================
  Files         402      402              
  Lines       37712    37712              
==========================================
+ Hits        24074    24315     +241     
+ Misses      12017    11773     -244     
- Partials     1621     1624       +3
Impacted Files Coverage Δ
etcdserver/api/v3rpc/watch.go 78.43% <0%> (-2.29%) ⬇️
pkg/proxy/server.go 60.2% <0%> (-1.02%) ⬇️
etcdserver/cluster_util.go 56.52% <0%> (-0.8%) ⬇️
raft/raft.go 89.85% <0%> (-0.66%) ⬇️
etcdserver/v3_server.go 71.52% <0%> (+0.22%) ⬆️
etcdserver/server.go 68.39% <0%> (+0.26%) ⬆️
clientv3/leasing/kv.go 90.36% <0%> (+0.66%) ⬆️
mvcc/watchable_store.go 83.5% <0%> (+0.7%) ⬆️
clientv3/watch.go 91.15% <0%> (+0.84%) ⬆️
etcdserver/api/v2http/client.go 85.51% <0%> (+1.2%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d823e7...434c973. Read the comment docs.

@carlosedp carlosedp changed the title Update x/sys and x/net modules to support Risc-V all: update x/sys and x/net modules to support Risc-V Aug 12, 2019
@carlosedp
Copy link
Contributor Author

Due to the Go module timestamp check, grpc 1.22.1 was failing with error:

go: google.golang.org/grpc@v1.22.1-0.20190805101010-a2bdfb40ff25: invalid pseudo-version: does not match version-control timestamp (2019-08-06T16:34:46Z)

Updating to named 1.22.1 version fixes this.

@carlosedp
Copy link
Contributor Author

Rebased and updated x/net due to a new validation by Go 1.13:

GO_BUILD_FLAGS="-v" ./build
get "golang.org/x/net": found meta tag get.metaImport{Prefix:"golang.org/x/net", VCS:"git", RepoRoot:"https://go.googlesource.com/net"} at //golang.org/x/net?go-get=1
go: golang.org/x/net@v0.0.0-20190813000000-74dc4d7220e7: invalid pseudo-version: does not match version-control timestamp (2019-08-13T14:13:03Z)
make: *** [Makefile:15: build] Error 1

@gyuho
Copy link
Contributor

gyuho commented Aug 29, 2019

@carlosedp Can you change git commit title to vendor: ...?

Signed-off-by: Carlos de Paula <me@carlosedp.com>
@carlosedp carlosedp changed the title all: update x/sys and x/net modules to support Risc-V vendor: update x/sys and x/net modules to support Risc-V Aug 29, 2019
@carlosedp
Copy link
Contributor Author

@gyuho Done! Changed the PR title too.

@carlosedp
Copy link
Contributor Author

Passed all! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants