-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.1.0 #33
Comments
@serathius @spzala I suggest to release gofail 0.1.0, so that all users (e.g etcd) depend on a tag version. |
+1 sounds good to me. Thanks @ahrtr |
One thought, we plan a couple of breaking changes to get gofail useful for linearizability tests. One example is removing package name from the failpoint name as it makes moving code an incompatible change, complicating multi version testing. I would like to avoid situation where just after a release we imminently change whole API. There are a lot of rough edges and proper integration with linearizability tests should allow us to smooth them out. Possibly for v0.1.0 release smooth experience is not needed, however tagging release is also technically not nesesery. You could argue that package didn't required any changes before. Problem is that it was not well utilized before. For example whole |
Could you raise issues in this repo to track the changes you proposed?
This might not be a good example. I wouldn't say |
I think it's time to release a tag version for gofail. We have already supported setting multiple failpoints. Please let me know if you have any concern. |
Would like to get etcd-io/etcd#14727 in. In introduced breaking change in name of failpoints. Let me know if we should accelerate work on it. |
All planned tasks/PRs are done. It's time to create the |
Let's release the first formal version v0.1.0, and update etcd to pin to the specific version.
We start to track changes in https://github.com/etcd-io/gofail/blob/master/CHANGELOG.md
cc @ptabor @serathius @spzala
WDYT?
The text was updated successfully, but these errors were encountered: