Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requests not working from browser #108

Closed
shanejonas opened this issue Aug 4, 2019 · 1 comment · Fixed by #109 or #110
Closed

requests not working from browser #108

shanejonas opened this issue Aug 4, 2019 · 1 comment · Fixed by #109 or #110
Labels
bug Something isn't working released

Comments

@shanejonas
Copy link
Contributor

shanejonas commented Aug 4, 2019 •
edited
Loading

Describe the bug
From the browser, requests do not complete.

To Reproduce

  1. use pristine-cli to create a new pristine-typescript-react project.
  2. npm install @etclabscore/jade-service-runner-client
const client = new JadeServiceRunnerClient({
  transport: {
    port: 8002,
    host: "localhost"
  }
));
await client.installService("multi-geth", "1.9.0");
  1. see request does not complete
  2. see screenshots

Expected behavior
Request should complete in the browser

Screenshots
image
@shanejonas shanejonas added the bug Something isn't working label Aug 4, 2019
@triage-new-issues triage-new-issues bot removed the triage label Aug 4, 2019
zcstarr added a commit that referenced this issue Aug 4, 2019
@zcstarr
fix:cors support for httpfrontend
692a625 
fixes #108
@zcstarr zcstarr mentioned this issue Aug 4, 2019
Merged
zcstarr added a commit that referenced this issue Aug 4, 2019
@zcstarr
fix:cors support for httpfrontend
861ce58 
fixes #108
zcstarr added a commit that referenced this issue Aug 4, 2019
@zcstarr
fix:cors support for httpfrontend
1083714 
fixes #108
zcstarr added a commit that referenced this issue Aug 4, 2019
@zcstarr
fix: cors support for httpfrontend
ab364f8 
fixes #108
@zcstarr zcstarr mentioned this issue Aug 4, 2019
Merged
@zcstarr
Copy link
Contributor

zcstarr commented Aug 4, 2019

🎉 This issue has been resolved in version 1.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

zcstarr added a commit to zcstarr/jade-service-runner that referenced this issue Aug 26, 2019
@zcstarr
fix:cors support for httpfrontend
5997b3b 
fixes etclabscore#108
zcstarr added a commit to zcstarr/jade-service-runner that referenced this issue Aug 27, 2019
@zcstarr
fix:cors support for httpfrontend
4af8a51 
fixes etclabscore#108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
2 participants
@zcstarr @shanejonas