-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECIP-1086: SLOAD Gas Patch for the Testnets #293
Conversation
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm from editor pov. I disagree with the approach on having testnet specific ecips. Testnets are for testing not only what will be deployed but how it will be deployed and should match mainnet implementations exactly
SNIP ... text from ETC Discord discussions moved to the Github issue for discussion: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
editorially ok
LGTM, merging |
Issues with the Aztlán protocol upgrades were identified and sufficiently patched with the Phoenix protocol upgrades. However, the subsequent activation of these upgrades on the Kotti and Mordor testnets revealed inconsistencies between client implementations. This document proposes a patch for the aforementioned testnets.
Abstract
The EIP-2200 defines structured definitions of net-gas metering for the
SSTORE
opcode. This EIP was activated in a bundle called EIP-1679 "Istanbul" on the Ethereum Foundation network and ECIP-1061 "Aztlán" on the Ethereum Classic network.Notably, the difference here is that Istanbul contained EIP-1884 which repriced various opcodes for trie-size dependent operations, whereas Aztlán did not.
Both EIP-1884 and EIP-2200 propose the
SLOAD_GAS
to be increased from200
to800
but not all clients correctly implemented this change for both EIPs leaving networks configured with a pick-and-mix EIP configuration such as Aztlán with an incompatible configuration as compared to clients who correctly implemented the specifications.Motivation
This specification seeks to validate the incomplete configuration in favor of retaining the Kotti and Mordor testnets in consensus. This ECIP shall not be considered on mainnet. It's sole purpose is to allow avoiding a rollback on the testnets and having a proper documentation on the cause for the gas mismatch and providing instructions for client developers how to circumvent this.
Discussions to: