Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fognum sometimes goes way out of range #21

Open
ensiform opened this issue Apr 13, 2018 · 7 comments
Open

Fognum sometimes goes way out of range #21

ensiform opened this issue Apr 13, 2018 · 7 comments

Comments

@ensiform
Copy link
Member

I am having sporadic cases where fognum becomes 31 after sort is processed so it seems likely that there is an issue with the shifting into the sort value but I cannot figure out what that is.

Help on finding the cause would be greatly appreciated.

@ensiform
Copy link
Member Author

ensiform commented Dec 5, 2018

Very difficult to reproduce right now and can't even track down a specific map.

@tsiren
Copy link
Collaborator

tsiren commented Jan 24, 2019

fognum variable defined where and which sort function?

@ensiform
Copy link
Member Author

I Believe it was detected out of range at the time in RB_CalcFogTexCoords.

See RB_RenderDrawSurfList R_DecomposeSort R_SortDrawSurfs R_AddDrawSurf for possible areas that deal with the sort packed data (including fognum)

@tsiren
Copy link
Collaborator

tsiren commented Jan 25, 2019

Is there a specific error that occurred when this happened? By glance I cannot spot any range checking.

@ensiform
Copy link
Member Author

Trying remember but I think the shader pointer becomes access violation later down.

There should not need to be any range checking in backend rendering functions.

@tsiren
Copy link
Collaborator

tsiren commented Jan 25, 2019

I don't think I have seen this one. You can decrease the priority then.

@ensiform
Copy link
Member Author

Don't think I've seen this issue come up at all in years either tbh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants