Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support binding to port 0 #1478

Open
BlinkyStitt opened this issue Mar 19, 2022 · 0 comments
Open

Support binding to port 0 #1478

BlinkyStitt opened this issue Mar 19, 2022 · 0 comments

Comments

@BlinkyStitt
Copy link
Collaborator

BlinkyStitt commented Mar 19, 2022

Overview

When running multiple test workers, brownie currently sets the port to port+1. This works most of the time, but only if there is a range of open ports.

More robust, would be to tell each node to bind to port 0 and then let the system decide which open port to use. Then we update brownie's config to use the assigned port and everything should work as normal.

At this time, I don't think we should change the default to 0 (though I think it is a better default). Instead, we should just make pytest -n do this and also support it if its assigned to 0 in network-config.yaml.

Hardhat currently supports binding to 0. Ganache does not (trufflesuite/ganache#2643).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant