Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User watching issue with unicode #9

Closed
ethan-nelson opened this issue Dec 2, 2015 · 3 comments
Closed

User watching issue with unicode #9

ethan-nelson opened this issue Dec 2, 2015 · 3 comments

Comments

@ethan-nelson
Copy link
Owner

Python is ignoring some names with Unicode characters. Need to change this comparison https://github.com/ethan-nelson/osm_hall_monitor/blob/master/osmhm/filters.py#L82 to allow Unicode characters and also wildcards.

@ethan-nelson
Copy link
Owner Author

Adding to the fnmatch call watched_user['username'].decode('utf-8') seems to help match. The other issue is the presence of spaces or lack thereof in the name--either in the watched name or in a name being checked.

@ethan-nelson
Copy link
Owner Author

Or rather, encoding the list of usernames from changesets to utf-8 will probably be more efficient in the long run. Confirmed that this solves the problem as well.

@ethan-nelson
Copy link
Owner Author

Fixed in 2bd8696.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant