Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current blockers #1

Open
1 of 3 tasks
ethanc8 opened this issue Jun 4, 2024 · 4 comments
Open
1 of 3 tasks

Current blockers #1

ethanc8 opened this issue Jun 4, 2024 · 4 comments

Comments

@ethanc8
Copy link
Owner

ethanc8 commented Jun 4, 2024

Here are the current blockers:

@ethanc8
Copy link
Owner Author

ethanc8 commented Jun 20, 2024

The CAAction protocol version being invalid has been fixed.

Right now, GitUpKit and the examples (GitY, GitDown, and GitDiff) build. GitY doesn't allow you to select repositories (the file picker only allows picking files), and GitDown and GitDiff allow selecting repositories and closing them but the actual diff interface is completely missing (the main window is empty). I think some of GitUpKit's unit tests fail, but I'm not sure exactly why.

@ethanc8
Copy link
Owner Author

ethanc8 commented Jun 20, 2024

Here's how GitDiff looks like right now after selecting a repository:

image

Screencast_20240614_142609.webm

It's supposed to look like this on macOS:

image

(I don't currently have access to a macOS machine, so I can't test it right now).

@ethanc8
Copy link
Owner Author

ethanc8 commented Jun 20, 2024

Note that this was after I patched the AppDelegates' -applicationShouldTerminateAfterLastWindowClosed: to return NO instead of YES:

- (BOOL)applicationShouldTerminateAfterLastWindowClosed:(NSApplication*)sender {
  return NO;
}

Before, when they returned YES, the app immediately quit after selecting the repository, without any explanation.

@ethanc8
Copy link
Owner Author

ethanc8 commented Jun 23, 2024

Updating gnustep-gui doesn't seem to do anything. I'm currently building from https://github.com/ethanc8/libs-gui/tree/ethanc8-6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant