Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP proxy support #28

Closed
julianxhokaxhiu opened this issue Nov 5, 2018 · 3 comments
Closed

HTTP proxy support #28

julianxhokaxhiu opened this issue Nov 5, 2018 · 3 comments
Labels

Comments

@julianxhokaxhiu
Copy link

Hi,

another missing feature I noticed missing, compared to require, is the support for HTTP proxy. The best would be to auto detect it based on environment variables and/or also as an option when calling phin.

What do you think? Are you interested in implementing it?

Best regards,
Julian

@julianxhokaxhiu
Copy link
Author

I was looking at some docus around and would be also awesome if you could provide an option to pass an Agent to the HTTP request. Then I would be able to autonomously pass an Agent done with https://www.npmjs.com/package/proxy-agent

@ethanent
Copy link
Owner

ethanent commented Jan 16, 2019

✔️ phin 3.3.0 adds this functionality!

await p({
   'url': 'https://ethanent.me',
   'core': {
      'agent': myAgent // Assuming you'd previously created Agent myAgent
   }
})

Thank you for your suggestion. 😄

@julianxhokaxhiu
Copy link
Author

Thanks, appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants