-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors in beforeSave and beforeRender hooks cause hangs #55
Comments
I'll look into this later tonight. You're right about both problems, but I'm not sure what's going on here. |
Actually, I probably won't be able to look into these issues until early next week, but I'll get to them ASAP. Thanks again for all the detailed reports! They're really making the library much more robust. Keep 'em coming! |
No problem. I'll give some of the easier ones a shot over the weekend. |
👍 |
@carlbennettnz Can you check if this is still an issue? I think it should have been fixed by 5018d8f. I.e., you should now be able to throw an error and have the request aborted and the error sent (in jsonapi format) back to the client. |
Works beautifully 👍 |
Related: I can't figure out how I'm supposed to handle errors there. You mentioned something about the
APIError
type, but throwing or returning that causes hangs too. How do I reject a request entirely?The text was updated successfully, but these errors were encountered: