Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for Input: Update Author's Username in EIP-1193 #325

Closed
SamWilsn opened this issue Mar 9, 2024 · 24 comments
Closed

Call for Input: Update Author's Username in EIP-1193 #325

SamWilsn opened this issue Mar 9, 2024 · 24 comments

Comments

@SamWilsn
Copy link
Collaborator

SamWilsn commented Mar 9, 2024

Call for Input

Decision

Do we merge https://github.com/ethereum/EIPs/pull/8290/files ?

If Affirmed

EIP-1193's author list is updated.

If Rejected No change.
Method Rough Consensus
Deadline April 7th, 2024

Background

@lightclient has verified the identity of the author. The old username has been re-registered by a different person.

@SamWilsn
Copy link
Collaborator Author

SamWilsn commented Mar 9, 2024

I am in favour of merging as long as the identity of the author is well verified.

@lightclient
Copy link

I am also in favor and have identified the individual.

@xinbenlv
Copy link

xinbenlv commented Mar 11, 2024

While I personally agree and want the individual to have the right to update their username despite EIP being final, wearing a EIP editor hat, it seems according to #308 this case shall be rejected, which I personally disagree but it was a case we made as a group so we shall follow the same rationale.

I ask my fellow EIP editors who vote in favor to provide a rationale of how this is different from #308 or we shall update our policy and revisit #308

For my part, @g11tech convinced me with this argument, roughly quoted:

EIPs aren't here to pump people's resumes. I can imagine someone bribing authors of a popular EIP to get authorship credit, and we don't want to be in the business of dealing with that.

I am against adding a new author.

One could argue that EIPs aren't seem to have any original purpose to collect airdrops, and whether we want to extend the EIP in the business of dealing with that, is doubtful.

@lightclient
Copy link

@xinbenlv this is different than #308 imo because we're changing the username of a listed author to be correct with their current username, rather than modifying the actual list of people.

@abcoathup
Copy link

I'm against (I don't have a vote).
I'm generally against any changes to final EIPs. Airdrop farmers registering old names sucks, but that should be on projects doing airdrops to deal with.

Given projects have done airdrops for EIP authors, there is incentives for unauthorized changes to be requested.
I wouldn't want EIP editors to be responsible for ensuring that these are valid changes. Far safer to not allow changes of final EIPs, and for EIPs in other states for only the current authors to change authors.

I strongly oppose any process which isn't repeatable by any author. Knowing an EIP editor shouldn't get you different/special treatment, than if you were a complete random. EIP editors shouldn't pick winners.

At the very least I would want a repeatable process.
Ideally a combination of both:

  • multiple authors of an EIP approve the GitHub name change
  • GitHub evidence that the name was changed by the author themselves

https://github.com/marcgarreau/mist-wallet redirects to https://github.com/wolovim/mist-wallet but don't know if there is a better way to prove.

The GitHub documentation refers to the redirects for name changes: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-user-account-settings/changing-your-github-username#repository-references

@poojaranjan poojaranjan mentioned this issue Mar 13, 2024
10 tasks
@xinbenlv
Copy link

xinbenlv commented Mar 13, 2024

Thank you @lightclient for answering. I have no objection if our lines is drawn at "updating username for EIP is ok even when it's a final EIP".

Case 2: Here is a similar case: someone sent me an email claiming to be ERC-5855 co-author and ask to update the user name

image

I've replied and ask them to present their case here too for us to consider the rule

Case 3: https://github.com/ethereum/ERCs/pull/285/files

@xinbenlv
Copy link

xinbenlv commented Mar 13, 2024

Propose to repurpose this Call for Input as "Policy involving updating author's username in EIP/ERCs" considering the 3 cases:

  1. For any authors who filed a PR to change their username in EIP/ERCs of final or any status allowing editing: if the lead author, individually, or a number of authors greater than half of the remaining authors, other than the requesting author, attested that the new username is the intended co-author by leaving a comment in the PR, the update to the username shall be considered legit.
  2. Given sufficient attestants, any single EIP editor shall be able to approve and merge the PR.
  3. Special case: if there is only one listed author, any EIP Editor could vouch for their identity, and another EIP Editor can merge the PR to update the username.

@bumblefudge
Copy link

s/legit/sufficiently authorized/*

@poojaranjan poojaranjan mentioned this issue Mar 13, 2024
16 tasks
@apan826
Copy link

apan826 commented Mar 14, 2024

I completely agree with the proposal raised by @xinbenlv. For a simple reason, we cannot accept that the name of a reward to me is not me. I think we need to have a way to update it. Thanks!

@lightclient
Copy link

I don't think we need more policies. There is enough work to do, we don't need arbitrary procedures for hypothetical issues holding us back.

@apan826
Copy link

apan826 commented Mar 15, 2024

I just think we need to have a way to update the wrong author name.

@lightclient
Copy link

We do, it's up to editor discretion.

@apan826
Copy link

apan826 commented Mar 15, 2024 via email

@apan826
Copy link

apan826 commented Mar 20, 2024

We do, it's up to editor discretion.

Hi, @lightclient Can you let me know what does "editor discretion" mean? I really want to update the author name of my EIP... thanks!

@wolovim
Copy link

wolovim commented Mar 20, 2024

data point possibly worth highlighting: as it stands, whoever is the current owner of marcgarreau has the potential to abuse this amendment approval ability. in practice, i'd have faith in the remaining EIP authors and editors to police it.

Screenshot 2024-03-20 at 11 04 09 AM

thats all from me though. thanks to you who've put brain power into it. 🫡

@xinbenlv
Copy link

I support authors to have a way to update their Github handle or contact information. @apan826 do you have a PR?

@xinbenlv
Copy link

I strongly oppose any process which isn't repeatable by any author. Knowing an EIP editor shouldn't get you different/special treatment, than if you were a complete random. EIP editors shouldn't pick winners.

I share @abcoathup 's view.

I created a Call for Input: #329

@apan826
Copy link

apan826 commented Mar 29, 2024

I support authors to have a way to update their Github handle or contact information. @apan826 do you have a PR?

Hi, @xinbenlv You mean the PR for updating my username in the author list of EIP5585? If yes, I did not create a PR yet, do I need to create one? Thanks.

@xinbenlv
Copy link

xinbenlv commented Mar 29, 2024

@apan826 Yes, please, and also have either your lead author approving it, or more than half of your other co-authors approve that PR as a way to validate the request, then I will go on to get it merged

@apan826
Copy link

apan826 commented Apr 7, 2024

Hi, @xinbenlv this is the PR created by our major author, thanks!
ethereum/ERCs#367

@g11tech
Copy link

g11tech commented Apr 8, 2024

its a terrible thing that other username has been registered by a different person, i am ok updating this but this is sort of a hassle we should avoid with some auto renaming or having a crypto identity (onchain or otherwise)

@SamWilsn
Copy link
Collaborator Author

General consensus is to affirm.

@apan826
Copy link

apan826 commented Apr 10, 2024

its a terrible thing that other username has been registered by a different person, i am ok updating this but this is sort of a hassle we should avoid with some auto renaming or having a crypto identity (onchain or otherwise)

Hi, @g11tech, it is a good point, I agree.

@apan826
Copy link

apan826 commented May 13, 2024

Hi, @xinbenlv @lightclient @SamWilsn @g11tech can we move to the link please and help to approve, ethereum/ERCs#405 , exactly the same thing, sorry and many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants