Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEO Render Request missing debounce second parameter #175

Closed
ccchapman opened this issue Jan 22, 2019 · 1 comment
Closed

SEO Render Request missing debounce second parameter #175

ccchapman opened this issue Jan 22, 2019 · 1 comment

Comments

@ccchapman
Copy link

Description

Modifying field content in my entries causes an ajax request (admin/actions/seo/render-data) for every single character typed. This is causing a massive overhead and crashing the browser session in some cases.

Steps to reproduce

  1. Open an entry
  2. Modify text in any fields
  3. View inspector network tab and see requests

screen shot 2019-01-21 at 4 47 13 pm

Additional info

  • Craft version: 3.1.3
  • SEO version: 3.5.1
  • PHP version: 7.2.11
@ccchapman
Copy link
Author

ccchapman commented Jan 22, 2019 •
edited
Loading

It appears like the debounce uses here are missing the timing parameter.

seo/resources/js/field/Snippet.js

Line 359 in 8434eff

debounce(this.onAnyChange.bind(this, [{target}]))

seo/resources/js/field/Snippet.js

Line 369 in 8434eff

debounce(this.onAnyChange.bind(this, [{target}]))

@ccchapman ccchapman changed the title SEO render data ajax request spam SEO Render Request missing debounce second parameter Jan 22, 2019
@Tam Tam closed this as completed in 2219ab2 Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ccchapman