Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Status Network Token to superchain token list #559

Merged
merged 6 commits into from
Nov 3, 2023
Merged

Add Status Network Token to superchain token list #559

merged 6 commits into from
Nov 3, 2023

Conversation

0x-r4bbit
Copy link
Contributor

No description provided.

@0x-r4bbit 0x-r4bbit requested review from a team as code owners October 26, 2023 10:44
@0x-r4bbit
Copy link
Contributor Author

The validation of this PR failed due to:

error: SNT on chain goerli token 0x3D6AFAA395C31FCd391fE3D562E75fe9E8ec7E6a has incorrect symbol
error: SNT on chain goerli token 0x3D6AFAA395C31FCd391fE3D562E75fe9E8ec7E6a has incorrect name

This is because on test nets, the token is called "Status Test Token" and "STT".
I've added overrides accordingly to account for that.

@spacesailor24 is this okay?

@spacesailor24
Copy link
Contributor

Yes, that's exactly the update I was going to ask you for. Re-running tests now and will merge if they pass

Thank you!

@0x-r4bbit
Copy link
Contributor Author

@spacesailor24 Thank you!

Another question: how did you verify the token address for Optimism is indeed provided by Status?
What if this was just some malicious address that the bridge will then bridge to when SNT is locked up on L1?

@0x-r4bbit
Copy link
Contributor Author

@spacesailor24 @tremarkley I've added another goerli-optimism entry here.

I'd appreciate another review and possible merge - thanks!

@0x-r4bbit
Copy link
Contributor Author

Without intending to push too hard here:

Is there an ETA at when I can expect this to be merged/available in the standard bridge UI?

@mergify mergify bot merged commit 50f0016 into ethereum-optimism:master Nov 3, 2023
2 checks passed
@nitaliano nitaliano mentioned this pull request Nov 3, 2023
Merged
@0x-r4bbit 0x-r4bbit mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roninjin10 roninjin10 roninjin10 approved these changes

@tremarkley tremarkley Awaiting requested review from tremarkley tremarkley was automatically assigned from ethereum-optimism/ecopod

@spacesailor24 spacesailor24 Awaiting requested review from spacesailor24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0x-r4bbit @spacesailor24 @roninjin10