Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wsteth is a dai bridge not a standard bridge #3159

Merged
merged 2 commits into from Aug 3, 2022
Merged

Conversation

roninjin10
Copy link
Contributor

In previous pr we added wsteth as a standard bridge but it turns out it's a dai bridge actually

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2022

⚠️ No Changeset found

Latest commit: d937423

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the A-pkg-sdk Area: packages/sdk label Aug 2, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 2, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@tynes
Copy link
Contributor

tynes commented Aug 3, 2022

This is due to the interface? How can i verify that this is correct?

@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 7b7dae0 into develop Aug 3, 2022
@mergify mergify bot deleted the willc/wseth-dai branch August 3, 2022 19:14
@mergify mergify bot removed the on-merge-train label Aug 3, 2022
@mslipper mslipper mentioned this pull request Aug 4, 2022
@roninjin10
Copy link
Contributor Author

Oops failed to include a changeset here

@tynes yea I originally assumed it was a standard bridge but they reached out to us telling us we made a mistake and it's a DAI bridge. I should have recorded video but chaning it to DAI got rid of the error they were seeing.
image

roninjin10 added a commit that referenced this pull request Aug 26, 2022
Co-authored-by: Will Cory <willcory@Wills-MacBook-Pro.local>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
maurelian pushed a commit that referenced this pull request Sep 15, 2022
Co-authored-by: Will Cory <willcory@Wills-MacBook-Pro.local>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sam-goldman pushed a commit that referenced this pull request Sep 15, 2022
Co-authored-by: Will Cory <willcory@Wills-MacBook-Pro.local>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nitaliano pushed a commit that referenced this pull request May 20, 2024
Co-authored-by: Will Cory <willcory@Wills-MacBook-Pro.local>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pkg-sdk Area: packages/sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants