Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ctb): add MigrationSystemDictator checks #3878

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Conversation

smartcontracts
Copy link
Contributor

Description
Adds checks for the MigrationSystemDictator steps.

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2022

⚠️ No Changeset found

Latest commit: fe16307

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Nov 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #3878 (6d5fc6d) into develop (e1d468b) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 6d5fc6d differs from pull request most recent head a7c12f4. Consider uploading reports for the commit a7c12f4 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3878      +/-   ##
===========================================
- Coverage    57.68%   57.62%   -0.07%     
===========================================
  Files          349      324      -25     
  Lines        19319    18630     -689     
  Branches       765      638     -127     
===========================================
- Hits         11145    10735     -410     
+ Misses        7245     6973     -272     
+ Partials       929      922       -7     
Flag Coverage Δ
bedrock-go-tests 56.70% <ø> (+0.13%) ⬆️
contracts-bedrock-tests 38.34% <ø> (ø)
contracts-governance-tests ?
contracts-periphery-tests 96.49% <ø> (ø)
contracts-tests 98.92% <ø> (ø)
core-utils-tests ?
dtl-tests 47.15% <ø> (ø)
fault-detector-tests 33.62% <ø> (ø)
sdk-tests 41.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/sources/l1_client.go 73.33% <0.00%> (-6.67%) ⬇️
op-node/p2p/discovery.go 65.97% <0.00%> (-2.41%) ⬇️
packages/core-utils/src/optimism/fees.ts
packages/core-utils/src/common/bn.ts
packages/core-utils/src/common/hex-strings.ts
...ntracts-governance/contracts/MerkleDistributor.sol
...ges/core-utils/src/optimism/deposit-transaction.ts
packages/core-utils/src/index.ts
packages/core-utils/src/optimism/batch-encoding.ts
packages/core-utils/src/common/test-utils.ts
... and 24 more

@mslipper mslipper changed the base branch from develop to 11-06-op-e2e_Add_migration_to_op-e2e November 7, 2022 20:21
@mslipper
Copy link
Collaborator

mslipper commented Nov 7, 2022

@smartcontracts smartcontracts marked this pull request as ready for review November 7, 2022 22:54
@mslipper mslipper force-pushed the 11-06-op-e2e_Add_migration_to_op-e2e branch from 8a07208 to 357f927 Compare November 9, 2022 19:31
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Nov 9, 2022
@mslipper mslipper force-pushed the 11-06-op-e2e_Add_migration_to_op-e2e branch 8 times, most recently from a995454 to ff915b4 Compare November 10, 2022 17:45
Base automatically changed from 11-06-op-e2e_Add_migration_to_op-e2e to develop November 10, 2022 18:38
@mergify mergify bot removed the conflict label Nov 10, 2022
Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly small things, generally looks good to me

Adds checks for the MigrationSystemDictator steps.
@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2022

This PR has been added to the merge queue, and will be merged soon.

mergify bot added a commit that referenced this pull request Nov 11, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 63142c9 into develop Nov 11, 2022
@mergify mergify bot deleted the sc/ctb-msd-checks branch November 11, 2022 00:45
@mergify mergify bot removed the on-merge-train label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pkg-contracts-bedrock Area: packages/contracts-bedrock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants