-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ctb): add MigrationSystemDictator checks #3878
Conversation
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #3878 +/- ##
===========================================
- Coverage 57.68% 57.62% -0.07%
===========================================
Files 349 324 -25
Lines 19319 18630 -689
Branches 765 638 -127
===========================================
- Hits 11145 10735 -410
+ Misses 7245 6973 -272
+ Partials 929 922 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
6d5fc6d
to
a7c12f4
Compare
a7c12f4
to
d4d62a2
Compare
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
d4d62a2
to
582841b
Compare
8a07208
to
357f927
Compare
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review. |
a995454
to
ff915b4
Compare
582841b
to
370a053
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly small things, generally looks good to me
packages/contracts-bedrock/deploy/018-MigrationSystemDictatorSteps.ts
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/deploy/018-MigrationSystemDictatorSteps.ts
Outdated
Show resolved
Hide resolved
Adds checks for the MigrationSystemDictator steps.
370a053
to
fe16307
Compare
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
Adds checks for the MigrationSystemDictator steps.