-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-batcher: Shutdown pprof and metrics after main loop returns #5345
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it should work.
cd9b3d1
to
5712cee
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5345 +/- ##
===========================================
- Coverage 39.09% 35.54% -3.56%
===========================================
Files 393 238 -155
Lines 26144 21638 -4506
Branches 838 0 -838
===========================================
- Hits 10222 7691 -2531
+ Misses 15141 13204 -1937
+ Partials 781 743 -38
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
The batcher's main function currently stops pprof and metrics immediately when receiving any stop signal, like SIGINT. This PR swaps the order and let's it first wait for the main loop to return and only then cancel pprof and metrics.
The error from stopping the http server is now also logged.
TODOs