Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(batcher): apply op-batcher v1.0.3 to Kroma #39

Merged
merged 1 commit into from
Apr 27, 2023
Merged

feat(batcher): apply op-batcher v1.0.3 to Kroma #39

merged 1 commit into from
Apr 27, 2023

Conversation

seolaoh
Copy link
Contributor

@seolaoh seolaoh commented Apr 24, 2023 •
edited
Loading

Description

v1.0.3

v1.0.2

v1.0.1

Other changes

@seolaoh seolaoh requested a review from a team as a code owner April 24, 2023 12:59
@seolaoh seolaoh marked this pull request as draft April 24, 2023 13:01
@seolaoh seolaoh self-assigned this Apr 24, 2023
@seolaoh seolaoh marked this pull request as ready for review April 24, 2023 13:26
chokobole
chokobole reviewed Apr 24, 2023
View reviewed changes
utils/service/rpc/server.go Outdated Show resolved Hide resolved
components/batcher/channel_builder.go Show resolved Hide resolved
utils/service/txmgr/metrics/tx_metrics.go Outdated Show resolved Hide resolved
utils/service/txmgr/price_bump_test.go Show resolved Hide resolved
@seolaoh seolaoh changed the title [WIP] feat(batcher): apply op-batcher v1.0.3 to Kroma feat(batcher): apply op-batcher v1.0.3 to Kroma Apr 25, 2023
@seolaoh seolaoh force-pushed the feat/apply-optimism-v1.0.3-batcher branch from a2cecae to 3bc8592 Compare April 25, 2023 02:52
chokobole
chokobole reviewed Apr 25, 2023
View reviewed changes
components/batcher/batcher.go Outdated Show resolved Hide resolved
utils/service/txmgr/cli.go Show resolved Hide resolved
@seolaoh seolaoh force-pushed the feat/apply-optimism-v1.0.3-batcher branch 2 times, most recently from 14775b2 to 20fdbd9 Compare April 25, 2023 08:59
0xHansLee
0xHansLee reviewed Apr 25, 2023
View reviewed changes
components/batcher/batcher.go Outdated Show resolved Hide resolved
utils/service/txmgr/txmgr.go Outdated Show resolved Hide resolved
utils/service/txmgr/txmgr.go Outdated Show resolved Hide resolved
utils/service/txmgr/txmgr.go Show resolved Hide resolved
chokobole
chokobole reviewed Apr 25, 2023
View reviewed changes
components/batcher/channel_manager.go Outdated Show resolved Hide resolved
utils/service/txmgr/mocks/TxManager.go Show resolved Hide resolved
utils/service/txmgr/mocks/TxManager.go Show resolved Hide resolved
utils/service/txmgr/txmgr.go Outdated Show resolved Hide resolved
utils/service/txmgr/txmgr.go Show resolved Hide resolved
utils/service/txmgr/txmgr.go Outdated Show resolved Hide resolved
utils/service/txmgr/txmgr.go Show resolved Hide resolved
utils/service/txmgr/txmgr.go Show resolved Hide resolved
utils/service/txmgr/txmgr_test.go Outdated Show resolved Hide resolved
utils/service/txmgr/txmgr_test.go Outdated Show resolved Hide resolved
@seolaoh seolaoh force-pushed the feat/apply-optimism-v1.0.3-batcher branch from 20fdbd9 to 3ad0f48 Compare April 26, 2023 07:44
chokobole
chokobole approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@chokobole chokobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seolaoh seolaoh force-pushed the feat/apply-optimism-v1.0.3-batcher branch from 3ad0f48 to cd5e9f4 Compare April 26, 2023 11:35
@seolaoh seolaoh force-pushed the feat/apply-optimism-v1.0.3-batcher branch from cd5e9f4 to 1802156 Compare April 27, 2023 01:23
@seolaoh seolaoh merged this pull request into feat/apply-optimism-v1.0.3 Apr 27, 2023
@seolaoh seolaoh deleted the feat/apply-optimism-v1.0.3-batcher branch April 27, 2023 01:24
@seolaoh seolaoh mentioned this pull request May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chokobole chokobole chokobole approved these changes

@0xHansLee 0xHansLee Awaiting requested review from 0xHansLee

@Pangssu Pangssu Awaiting requested review from Pangssu

Assignees

@seolaoh seolaoh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seolaoh @Pangssu @chokobole @0xHansLee