Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-program: Re-add caching wrapper to oracles. #5587

Merged
merged 2 commits into from
May 3, 2023
Merged

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented May 3, 2023

Description

The caching wrapper for oracles had been lost as part of changes to fault proof client startup. Re-add them and increase the l2 block cache size so it covers the likely number of L1 block it has to walk back to as part of resetting the derivation pipeline.

The numbers don't have to be perfect - the current numbers were checked by running a verification against Goerli. Even when replaying 2000 blocks it was only the l2 block cache limit that was hit because of that initial walk back. Other caches seem to be a reasonable size (not too big to cause memory issues but big enough to not have to evict items in normal cases).

Also found some of the old setup code that was no longer used so deleted it.

Metadata

@ajsutton ajsutton requested a review from a team as a code owner May 3, 2023 05:18
@ajsutton ajsutton requested a review from sebastianst May 3, 2023 05:18
@changeset-bot
Copy link

changeset-bot bot commented May 3, 2023

⚠️ No Changeset found

Latest commit: 6b53597

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 3, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 6b53597
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6452d79b46288400086abfd5

Increase cache size for l2 blocks.
@mergify
Copy link
Contributor

mergify bot commented May 3, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 3, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented May 3, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit b0e56a4 into develop May 3, 2023
@OptimismBot OptimismBot deleted the aj/fpp-fix-cache branch May 3, 2023 22:07
@mergify mergify bot removed the on-merge-train label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants