feat(pops): Refactor Challenger for Testability

[refcell]

Description

Cleans up the op-challenger to follow the op-program's format so we can test cli args easily.

NOTE: challenger/utils.go will be removed in #5622 :)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 666f490

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for opstack-docs canceled.

Name	Link
🔨 Latest commit	666f490
🔍 Latest deploy log	https://app.netlify.com/sites/opstack-docs/deploys/64581719ce5d320008638784

[mergify]

Hey @refcell! This PR has merge conflicts. Please fix them before continuing review.

[ajsutton]

LGTM.

Worth noting that the CheckRequired method in flags.go isn't being called now. The config checks pick it up but the error message they give is slightly less useful because it doesn't include the specific CLI option name that's missing (ie you get missing l1 eth rpc urlinstead of flag --l1-eth-rpc is required).

I suggest hooking that back up in the next PR and adding tests for the CLI flags to cover it. You do get a bit of duplication between the config tests and flag tests but they're quite simple tests and cli vs config are their own separate concerns so worth testing individually. Plus the CLI tests cover the actual parsing which can provide some surprises at times.

[mergify]

This PR has been added to the merge queue, and will be merged soon.

[mergify]

This PR is next in line to be merged, and will be merged as soon as checks pass.

[mergify]

This PR is next in line to be merged, and will be merged as soon as checks pass.