Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pops): Flag Tests for the Challenger #5634

Merged
merged 2 commits into from
May 8, 2023
Merged

feat(pops): Flag Tests for the Challenger #5634

merged 2 commits into from
May 8, 2023

Conversation

refcell
Copy link
Contributor

@refcell refcell commented May 8, 2023

Description

Follows @ajsutton's suggestion of adding back in the flags CheckRequired when creating the config from cli. Also adds flag tests.

@changeset-bot
Copy link

changeset-bot bot commented May 8, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 71cb939

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@refcell refcell self-assigned this May 8, 2023
@refcell refcell requested a review from ajsutton May 8, 2023 12:53
@netlify
Copy link

netlify bot commented May 8, 2023 •
edited
Loading

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 71cb939
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64596c5ed17b6700083240b1

@refcell refcell mentioned this pull request May 8, 2023
Merged
ajsutton
ajsutton approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We could add tests to confirm that we get an error if required flags aren't supplied as well.

@mergify
Copy link
Contributor

mergify bot commented May 8, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 8, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify
Copy link
Contributor

mergify bot commented May 8, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit c8ee624 into develop May 8, 2023
8 of 9 checks passed
@OptimismBot OptimismBot deleted the refcell/challenger/flags branch May 8, 2023 21:56
@mergify mergify bot removed the on-merge-train label May 8, 2023
trianglesphere
trianglesphere reviewed May 9, 2023
View reviewed changes
op-challenger/flags/flags_test.go
if envVar == "" {
t.Errorf("Failed to find EnvVar for flag %v", flag.GetName())
}
if envVar[:len("OP_CHALLENGER_")] != "OP_CHALLENGER_" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use https://pkg.go.dev/strings#HasPrefix here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trianglesphere trianglesphere trianglesphere left review comments

@ajsutton ajsutton ajsutton approved these changes

Assignees

@refcell refcell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@refcell @ajsutton @trianglesphere @OptimismBot