Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pops): Bond Manager #5649

Merged
merged 1 commit into from
May 10, 2023
Merged

feat(pops): Bond Manager #5649

merged 1 commit into from
May 10, 2023

Conversation

refcell
Copy link
Contributor

@refcell refcell commented May 8, 2023 •
edited

Description

Introduces the BondManager contract and associated tests for Permissionless Output Proposals.

Checklist

Metadata

Fixes CLI-3487

@refcell refcell self-assigned this May 8, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 8, 2023 •
edited

⚠️ No Changeset found

Latest commit: 1436e70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 8, 2023 •
edited

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 1436e70
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/645bb5fc917ce9000820cbd3

@refcell refcell force-pushed the refcell/bond/manager branch 3 times, most recently from 3ab0e75 to 6dc790b Compare May 9, 2023 17:52
@refcell refcell marked this pull request as ready for review May 9, 2023 17:52
@refcell refcell requested a review from a team as a code owner May 9, 2023 17:52
@refcell refcell requested review from tynes and clabby May 9, 2023 17:52
@refcell refcell force-pushed the refcell/bond/manager branch 2 times, most recently from 6cab960 to 9bdc743 Compare May 9, 2023 21:15
@refcell refcell requested a review from maurelian May 9, 2023 22:02
@refcell refcell requested a review from tynes May 10, 2023 01:36
@refcell refcell mentioned this pull request May 10, 2023
Merged
@refcell refcell requested a review from a team as a code owner May 10, 2023 15:18
clabby
clabby approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Ports existing BondManager to ctb style.

@OptimismBot OptimismBot merged commit 931e1de into develop May 10, 2023
@OptimismBot OptimismBot deleted the refcell/bond/manager branch May 10, 2023 15:36
@mergify
Copy link
Contributor

mergify bot commented May 10, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 10, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

@maurelian maurelian Awaiting requested review from maurelian

@tynes tynes Awaiting requested review from tynes

Assignees

@refcell refcell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@refcell @tynes @clabby @OptimismBot