Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ctb): SafeCall send function to call with zero calldata bytes #5675

Merged
merged 2 commits into from
May 10, 2023
Merged

feat(ctb): SafeCall send function to call with zero calldata bytes #5675

merged 2 commits into from
May 10, 2023

Conversation

refcell
Copy link
Contributor

@refcell refcell commented May 10, 2023 •
edited
Loading

Description

Splits the SafeCall send function into a separate PR which calls the target with zero calldata bytes and the specified value. Split out of the pr in #5649

@refcell refcell requested a review from a team as a code owner May 10, 2023 02:19
@refcell refcell requested a review from maurelian May 10, 2023 02:19
@changeset-bot
Copy link

changeset-bot bot commented May 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: d976350

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 10, 2023 •
edited
Loading

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit d976350
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/645bad244aac3900080d46dc

@refcell refcell requested review from tynes and clabby May 10, 2023 02:19
@refcell refcell mentioned this pull request May 10, 2023
Merged
2 tasks
clabby
clabby approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented May 10, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 10, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented May 10, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit af98296 into develop May 10, 2023
8 of 9 checks passed
@OptimismBot OptimismBot deleted the refcell/safecall/send branch May 10, 2023 14:59
@mergify mergify bot removed the on-merge-train label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

@maurelian maurelian Awaiting requested review from maurelian maurelian is a code owner automatically assigned from ethereum-optimism/contract-reviewers

@tynes tynes Awaiting requested review from tynes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@refcell @clabby @OptimismBot