-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-program: Update goerli verification script to handle long safe head stalls #5686
Conversation
…d stalls Uses the latest output if there isn't an output after the current finalized block and checks it's at or before the finalized block.
|
✅ Deploy Preview for opstack-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Will put up another PR to remove the println
in this file - that's an old builtin that we shouldn't be using
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Will put up another PR to remove the println
in this file - that's an old builtin that we shouldn't be using
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5686 +/- ##
===========================================
+ Coverage 16.52% 17.15% +0.63%
===========================================
Files 266 93 -173
Lines 17906 10478 -7428
Branches 199 0 -199
===========================================
- Hits 2959 1798 -1161
+ Misses 14717 8470 -6247
+ Partials 230 210 -20
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
Uses the latest output if there isn't an output after the current finalized block and checks it's at or before the finalized block.
Avoids failures like https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/17993/workflows/fa162c20-dc53-4c24-b2e3-7312e9574116/jobs/702292