Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-program: Update goerli verification script to handle long safe head stalls #5686

Merged
merged 2 commits into from
May 11, 2023

Conversation

ajsutton
Copy link
Contributor

Description

Uses the latest output if there isn't an output after the current finalized block and checks it's at or before the finalized block.

Avoids failures like https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/17993/workflows/fa162c20-dc53-4c24-b2e3-7312e9574116/jobs/702292

…d stalls

Uses the latest output if there isn't an output after the current finalized block and checks it's at or before the finalized block.
@ajsutton ajsutton requested a review from a team as a code owner May 11, 2023 00:00
@changeset-bot
Copy link

changeset-bot bot commented May 11, 2023

⚠️ No Changeset found

Latest commit: d93c28c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit d93c28c
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/645d1dc8c0e29a00084d9da3

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Will put up another PR to remove the println in this file - that's an old builtin that we shouldn't be using

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Will put up another PR to remove the println in this file - that's an old builtin that we shouldn't be using

@mergify
Copy link
Contributor

mergify bot commented May 11, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 11, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify
Copy link
Contributor

mergify bot commented May 11, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #5686 (d93c28c) into develop (a5a5529) will increase coverage by 0.63%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5686      +/-   ##
===========================================
+ Coverage    16.52%   17.15%   +0.63%     
===========================================
  Files          266       93     -173     
  Lines        17906    10478    -7428     
  Branches       199        0     -199     
===========================================
- Hits          2959     1798    -1161     
+ Misses       14717     8470    -6247     
+ Partials       230      210      -20     
Flag Coverage Δ
bedrock-go-tests 17.15% <ø> (+2.57%) ⬆️
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 237 files with indirect coverage changes

@OptimismBot OptimismBot merged commit c0e63f2 into develop May 11, 2023
@OptimismBot OptimismBot deleted the aj/fpp-delayed-safe-head branch May 11, 2023 17:09
@mergify mergify bot removed the on-merge-train label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants