-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-node: Remove ConnGater and ConnMngr constructors from p2p config #5733
Conversation
The config was calling these itself from the Host method and nothing actually used the ability to further customize them.
|
✅ Deploy Preview for opstack-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem fine. Note that hive p2p test failed. Rerunning to see if it was a flake or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2P hive test passed.
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5733 +/- ##
===========================================
- Coverage 41.51% 39.20% -2.31%
===========================================
Files 426 290 -136
Lines 28500 24486 -4014
Branches 753 0 -753
===========================================
- Hits 11832 9600 -2232
+ Misses 15720 13989 -1731
+ Partials 948 897 -51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
Removes the ConnGater and ConnMngr constructors from p2p config. The config was calling these itself from the Host method and nothing actually used the ability to further customize them.
Tests
No actual change in behaviour, just simplified init process.