Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: Remove ConnGater and ConnMngr constructors from p2p config #5733

Merged
merged 2 commits into from
May 18, 2023

Conversation

ajsutton
Copy link
Contributor

Description

Removes the ConnGater and ConnMngr constructors from p2p config. The config was calling these itself from the Host method and nothing actually used the ability to further customize them.

Tests

No actual change in behaviour, just simplified init process.

The config was calling these itself from the Host method and nothing actually used the ability to further customize them.
@ajsutton ajsutton requested a review from a team as a code owner May 18, 2023 04:34
@ajsutton ajsutton requested a review from mslipper May 18, 2023 04:34
@changeset-bot
Copy link

changeset-bot bot commented May 18, 2023

⚠️ No Changeset found

Latest commit: cdd748e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 18, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit cdd748e
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64665d33f0ba5e000753dbeb

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem fine. Note that hive p2p test failed. Rerunning to see if it was a flake or not.

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2P hive test passed.

@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #5733 (cdd748e) into develop (623ece1) will decrease coverage by 2.31%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5733      +/-   ##
===========================================
- Coverage    41.51%   39.20%   -2.31%     
===========================================
  Files          426      290     -136     
  Lines        28500    24486    -4014     
  Branches       753        0     -753     
===========================================
- Hits         11832     9600    -2232     
+ Misses       15720    13989    -1731     
+ Partials       948      897      -51     
Flag Coverage Δ
bedrock-go-tests 39.20% <100.00%> (+0.01%) ⬆️
common-ts-tests ?
contracts-bedrock-tests ?
contracts-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/p2p/cli/load_config.go 0.00% <ø> (ø)
op-node/p2p/config.go 38.00% <ø> (+4.07%) ⬆️
op-node/p2p/host.go 60.84% <100.00%> (ø)

... and 137 files with indirect coverage changes

@OptimismBot OptimismBot merged commit 5b31a02 into develop May 18, 2023
81 of 82 checks passed
@OptimismBot OptimismBot deleted the aj/remove-config branch May 18, 2023 17:30
@mergify mergify bot removed the on-merge-train label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants