op-node: Add persistence of peer scores in peer store #5732
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
ajsutton
force-pushed
the
aj/extended-peer-store
branch
2 times, most recently
from
e038e1c
to
3403457
Compare
|
Split out the simplification of init code to #5733 |
ajsutton
force-pushed
the
aj/extended-peer-store
branch
from
3403457
to
0fe44fb
Compare
| // TODO: This will need to be modified to use sys.Mocknet.AddPeerWithPeerstore so we can make the peerstore | ||
| // an extended peerstore. | ||
| h, err := sys.Mocknet.GenPeer() |
There was a problem hiding this comment.
This was an unfortunate discovery. Switching to specifying the peerstore ourselves will require duplicating a bit of code that GenPeer previously did. Alternatively we could introduce the ExtendedPeerStore wrapper later rather than it being the actual host Peerstore but it feels a lot nicer to have everything go through the wrapper.
There was a problem hiding this comment.
I updated the libp2p PR to so that GenPeer can take a PeerStore and/or ConnectionManager so we can duplicate code in the short term but hopefully migrate to those new APIs in a future go-libp2p version.
|
Hey @ajsutton! This PR has merge conflicts. Please fix them before continuing review. |
Doesn't actually use those stores to disconnect peers but updates the store with gossip scores.
ajsutton
force-pushed
the
aj/extended-peer-store
branch
from
0fe44fb
to
5b3ba8b
Compare
|
Hey @ajsutton! This PR has merge conflicts. Please fix them before continuing review. |
|
Done in separate PRs. |
Description
Introduces the concept of
ExtendedPeerstorewhich provides a type-safe API for storing additional peer data - initially peer scores from various scoring sources.Currently it doesn't actually use the information in the store but does update the store periodically with the latest gossip score for each peer. The extended peer store is also passed into the method that creates the connection gater to prove the plumbing all fits together but the gater hasn't been updated to actually use it.
Also simplifies the setup initialisation of the p2p layer by removing the connection gater and manager constructors from the config. These are both created as part of the
config.Hostcall anyway so the config has control over them.Currently scores are stored as meta entries for peers. This is simple but overly naive. The underlying
datastore.Batchinghas been passed into the constructor to ensure that it is available when being wired up as an optimised implementation will likely use that directly. We will have to implement some form of GC if we move out of using meta (but that will give us flexibility on how long to retain scoring information which is likely to be required anyway).Also pretty sure the API to get scores isn't the most useful thing. For disconnection we'll want to be able to get a total score value out rather than individual components, but not sure the peer store should be involved in applying weightings to calculate that score.
Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Invariants
For changes to critical code paths, please list and describe the invariants or key security properties of your new or changed code.
Additional context
Add any other context about the problem you're solving.
Metadata