You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix intermittency in TestChannelBuilder_PendingFrames_TotalFrames.
Different random seeds would result in varying compression levels in the generated blocks. When the expected compression ratio wasn't reached, the channel may use more frames than the target resulting in a test failure.
Test now uses a fixed seed for the rng and InsecureRandomKey is now deterministic.
InsecureRandomKey used to use ecdsa.GenerateKey but the Go authors in their infinite wisdom 🙄 made it explicitly non-deterministic even when the rng input is constant - even within the same process. So now it randomly (using the supplied rng) selects a key from a set of 300 hard coded keys.
Having unit tests be repeatable is a key requirement for stable builds - if we want to fuzz test, we should explicitly use fuzz testing utils which ensure the entropy seed is clearly logged on a failure so the failing case can be reproduced and debugged.
…alFrames
Different random seeds would result in varying compression levels which caused intermittency. Now uses a fixed seed for the rng and InsecureRandomKey is now deterministic.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
❗ Current head b2f24a1 differs from pull request most recent head 0c1c291. Consider uploading reports for the commit 0c1c291 to get more accurate results
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix intermittency in TestChannelBuilder_PendingFrames_TotalFrames.
Different random seeds would result in varying compression levels in the generated blocks. When the expected compression ratio wasn't reached, the channel may use more frames than the target resulting in a test failure.
Test now uses a fixed seed for the rng and InsecureRandomKey is now deterministic.
InsecureRandomKeyused to useecdsa.GenerateKeybut the Go authors in their infinite wisdom 🙄 made it explicitly non-deterministic even when the rng input is constant - even within the same process. So now it randomly (using the supplied rng) selects a key from a set of 300 hard coded keys.Having unit tests be repeatable is a key requirement for stable builds - if we want to fuzz test, we should explicitly use fuzz testing utils which ensure the entropy seed is clearly logged on a failure so the failing case can be reproduced and debugged.