-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-node: safer genesis script #6456
Conversation
Updates the `op-node` genesis gen script to prevent `nil` pointer access accidentally. Run the command like so: ```go go run op-node/cmd/main.go genesis l2 \ --deploy-config $PWD/packages/contracts-bedrock/deploy-config/mainnet.json \ --outfile.l2 l2.json \ --outfile.rollup rollup.json \ --l1-rpc $ETH_RPC_URL \ --deployment-dir $PWD/packages/contracts-bedrock/deployments/mainnet ``` When generating the genesis file, it is ok to leave the `l1StartingBlockTag` value as undefined, this script will select an appropriate value and then the value will end up inside of the rollup config under `.genesis.l1.hash` which can then be backported to the deploy config to make the script deterministic.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6456 +/- ##
===========================================
+ Coverage 40.74% 43.92% +3.17%
===========================================
Files 465 313 -152
Lines 33461 24951 -8510
Branches 1949 0 -1949
===========================================
- Hits 13634 10959 -2675
+ Misses 18350 12982 -5368
+ Partials 1477 1010 -467
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
Updates the
op-node
genesis gen script to preventnil
pointer access accidentally. Run the command like so:When generating the genesis file, it is ok to leave the
l1StartingBlockTag
value as undefined, this script will select an appropriate value and then the value will end up inside of the rollup config under.genesis.l1.hash
which can then be backported to the deploy config to make the script deterministic.A clear and concise description of the features you're adding in this pull request.