Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-node: safer genesis script #6456

Merged
merged 4 commits into from
Jul 26, 2023
Merged

op-node: safer genesis script #6456

merged 4 commits into from
Jul 26, 2023

Commits on Jul 26, 2023

  1. op-node: safer genesis script 

    Updates the `op-node` genesis gen script to prevent `nil` pointer
access accidentally. Run the command like so:

```go
go run op-node/cmd/main.go genesis l2 \
  --deploy-config $PWD/packages/contracts-bedrock/deploy-config/mainnet.json \
  --outfile.l2 l2.json \
  --outfile.rollup rollup.json \
  --l1-rpc $ETH_RPC_URL \
  --deployment-dir $PWD/packages/contracts-bedrock/deployments/mainnet
```

When generating the genesis file, it is ok to leave the
`l1StartingBlockTag` value as undefined, this script will select an
appropriate value and then the value will end up inside of the rollup
config under `.genesis.l1.hash` which can then be backported to
the deploy config to make the script deterministic.
    @tynes
    tynes committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ac6c0e8 View commit details
    Browse the repository at this point in the history

  2. op-node: cleanup genesis command

    @tynes
    tynes committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    74305be View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into fix/genesis-script

    @mergify
    mergify[bot] committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4f4afaa View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into fix/genesis-script

    @mergify
    mergify[bot] committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    a8a4b22 View commit details
    Browse the repository at this point in the history