Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethers.js integration and testing #102

Closed
wants to merge 3 commits into from
Closed

Ethers.js integration and testing #102

wants to merge 3 commits into from

Conversation

kpulkit29
Copy link

No description provided.

@gitcoinbot gitcoinbot mentioned this pull request Sep 25, 2018
Closed
4 tasks
@krzkaczor
Copy link
Member

Please remove package.lock we use yarn. CI fails, have you tried running yarn test:fix: to fix all autofixable problems?

krzkaczor
krzkaczor reviewed Sep 26, 2018
View reviewed changes
package.json Outdated
@@ -51,6 +53,7 @@
"dependencies": {
"command-line-args": "^4.0.7",
"debug": "^3.0.1",
"ethers": "^3.0.29",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be dev dependency

package.json Outdated
@@ -28,6 +28,8 @@
"chai": "^4.1.2",
"chai-as-promised": "^7.1.1",
"coveralls": "^3.0.2",
"ethers": "*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed

@kpulkit29
Copy link
Author

kpulkit29 commented Sep 27, 2018 via email

@krzkaczor krzkaczor closed this Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzkaczor krzkaczor krzkaczor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpulkit29 @krzkaczor