EIP-1 minors edits: clarify some sections on EIP collaborators and editors, cross-links, links, grammar, etc. #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jamesray1
commented
Apr 21, 2018
•
jamesray1
commented
- Add a link for Ethereum philosophy to the section in the white paper that was originally removed and which I re-added recently.
- Revise the format for the author header (names can be optional for anonymity).
- History edits (link to revision history + a minor edit).
- Add cross-links to other sections for better readability and clarity.
- Add clarifications on approval before merging from both editors and authors.
- Add more links for discussion channels
- Link to other clients and eips.ethereum.org.
- Reorder EIP editors roughly based on recent contributions.
- Other minor edits: grammar, etc.
Link for Ethereum philosophy to the section in the white paper that was originally removed and which I re-added recently, reorder EIP editors roughly based on recent contributions and add a note to say that Nick is the lead editor, merging most EIPs, History edits (link to revision history + a minor edit).
jamesray1
changed the title
… you can ping one of the Editors that is involved with your pull request"
…lic transparency)"
…ter they have finished editing it, and editors can ask if they have finished editing it and would like it to be merged. This prevents merging an EIP when more edits are intended to be made by the author, although it can always be edited after merging.)"
jamesray1
commented
Apr 21, 2018
| @@ -184,27 +184,27 @@ EIPs may include auxiliary files such as diagrams. Such files must be named EIP- | |||
| Transferring EIP Ownership | |||
| -------------------------- | |||
|
|
|||
| It occasionally becomes necessary to transfer ownership of EIPs to a new champion. In general, we'd like to retain the original author as a co-author of the transferred EIP, but that's really up to the original author. A good reason to transfer ownership is because the original author no longer has the time or interest in updating it or following through with the EIP process, or has fallen off the face of the 'net (i.e. is unreachable or not responding to email). A bad reason to transfer ownership is because you don't agree with the direction of the EIP. We try to build consensus around an EIP, but if that's not possible, you can always submit a competing EIP. | |||
| It occasionally becomes necessary to transfer ownership of EIPs to a new champion. In general, we'd like to retain the original author as a co-author of the transferred EIP, but that's really up to the original author. A good reason to transfer ownership is because the original author no longer has the time or interest in updating it or following through with the EIP process, or has fallen off the face of the 'net (i.e. is unreachable or isn't responding to email). A bad reason to transfer ownership is because you don't agree with the direction of the EIP. We try to build consensus around an EIP, but if that's not possible, you can always submit a competing EIP. | |||
There was a problem hiding this comment.
To make it easier to spot the change: isn't responding to email
jamesray1
changed the title
jamesray1
changed the title
|
OK please merge this, I'm done with editing. |
|
OK I made another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.