New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERC-1328 - WalletConnect Standard URI Format #1330
Conversation
EIPS/eip-1328.md
Outdated
authors: ligi <ligi@ligi.de>, Pedro Gomes <pedrouid@protonmail.com> | ||
type: Standards Track | ||
category: ERC | ||
status: WIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be draft
. If you don't want this PR merged, put [WIP]
in the PR title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR - just minor change requests and let's finish it then. Will already start the implementation in KEthereum and then WallETH as the changes are just in the wording for Humans - not in the specification itself.
EIPS/eip-1328.md
Outdated
|
||
## Simple Summary | ||
|
||
A standard way of creating WalletConnect URIs for establishing connections between wallets and dapps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would reword to:
A standard to create WalletConnect URIs for establishing connections between wallets and applications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to keep the sentence this way for some reason - please just add the "." on the end
EIPS/eip-1328.md
Outdated
|
||
## Abstract | ||
|
||
Sesion data in QR codes for initiating a connection between a wallet and dapp using the WalletConnect standard require a standardized URI format for effictively parsing the intenet. This ERC is expandable between versions of the standard and also mobile-to-mobile deep links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intenet needs to be changed as it is not a word ;-)
In general I would change it to:
This standard defines how the data to connect some application and a wallet can be encoded with a URI. This URI can then be shown either as a QR code or for mobile to mobile as a link.
EIPS/eip-1328.md
Outdated
|
||
## Rationale | ||
|
||
The need for this ERC stems from the discussion to move away from JSON format used in current beta version of the WalletConnect standard which makes for very inneficient parsing of the intent of the QR code, making it easier to create better QR code parsers APIs for Wallets to implement for other compatible EIPs using the ERC-831 URI format for Ethereum. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add.
Also by using a URI instead of a JSON inside the QR-Code the Android Intent system can be leveraged.
@pedrouid thanks! |
Following #1328