Add chain ids for ThunderCore Blockchain #1755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThunderCore (http://ThunderCore.com) is an EVM compatible blockchain which has both mainnet and testnet. We need to have separate chain ids for both of them. Please send any questions to chandan@thundercore.com
Ledger does not take 8888 as chain id.
Update eip-155.md
8888 is not accepted by Ledger.
|
The chain id doesn't seem to be stable, changing every couple of days. |
|
We found a conflict in MyEtherWallet database with previous chain-ids,
which we had selected. Hence the change. Additionally,H the chain-id > 128
were not supported by Ledger. Hence the second change.
The final version of the commit is the one which has no conflict with other
chain-ids. There will not be any more changes.
Please merge the pull request.
…On Thu, Feb 28, 2019 at 12:14 PM Alex Beregszaszi ***@***.***> wrote:
The chain id doesn't seem to be stable, changing every couple of days.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1755 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AteH7ug09waMergQtYmyEoohSyEtY10Aks5vSDiLgaJpZM4a-ryY>
.
|
|
@axic Any other concerns? Our mainnet (ThunderCore.com) with this chainid is already live. Merging this change will avoid any future conflicts in chainids. |
|
I'm going to suggest moving out the network id table and replace it with a link to a table that can be updated elsewhere. See #1703 |
chandanthundercore
added a commit
to chandanthundercore/chains
that referenced
this pull request
Mar 8, 2019
ThunderCore (ThunderCore.com) is an EVM compatible blockchain. It's testnet and mainnet are already live. We were redirected to this github page by the approver of this pull request: ethereum/EIPs#1755 Please merge these chainid changes to avoid any conflicts.
ligi
added a commit
to ligi/EIPs
that referenced
this pull request
Mar 8, 2019
rodger-dev95
added a commit
to rodger-dev95/evm-chains
that referenced
this pull request
Jun 10, 2022
ThunderCore (ThunderCore.com) is an EVM compatible blockchain. It's testnet and mainnet are already live. We were redirected to this github page by the approver of this pull request: ethereum/EIPs#1755 Please merge these chainid changes to avoid any conflicts.
ClarkWalker
added a commit
to ClarkWalker/chains
that referenced
this pull request
Nov 12, 2022
ThunderCore (ThunderCore.com) is an EVM compatible blockchain. It's testnet and mainnet are already live. We were redirected to this github page by the approver of this pull request: ethereum/EIPs#1755 Please merge these chainid changes to avoid any conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThunderCore (http://ThunderCore.com) is an EVM compatible blockchain which has both mainnet and testnet. We need to have separate chain ids for both of them. Please send any questions to chandan@thundercore.com
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-X.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: