Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip the list of chain ID's #1835

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Conversation

ligi
Copy link
Member

@ligi ligi commented Mar 8, 2019

Copy link
Contributor

@nicksavers nicksavers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a good idea to leave in mainnet and testnets like Morden and Ropsten.

@ligi
Copy link
Member Author

ligi commented Mar 8, 2019

yea - was also thinking about this when doing the change - but where to draw the line?-)

added a commit with a suggestion

@nicksavers nicksavers merged commit 5d81cc0 into ethereum:master Mar 8, 2019
@axic
Copy link
Member

axic commented Mar 8, 2019

I think this was a bad idea 😢

@Arachnid has expressed that maintaining registries separate from the EIP repo might be premature and I agree with that. This change moves towards that.

@nicksavers
Copy link
Contributor

nicksavers commented Mar 9, 2019

We can change it back, but as you may have noticed, many networks are already on that list and this is theoretically endless. This is pushing that responsibility off the proposal. We can also update the link to a different or multiple registries if necessary.

Edit: After thinking about it more, I came to the conclusion that you are probably right. I'll put back the list and we can argue (#1828) about creating an Active EIP to maintain the list. The list to the external list can remain of course.

ilanolkies pushed a commit to ilanolkies/EIPs that referenced this pull request Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants